Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GILReleaser to pick & place methods #2272

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

gerardcanal
Copy link
Contributor

Description

Added the GILReleaser Pattern to the pick and place operations to prevent thread blocking when those methods were called in python.

This should be merged after #2231 (as it includes the releaser in the methods added there).

Tested in melodic, it would be good to have it ported there too.

@v4hn and @gleichdick may be good candidates for review.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@v4hn
Copy link
Contributor

v4hn commented Aug 21, 2020

@gerardcanal now you just have to rebase this one more time :-)

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #2272 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
+ Coverage   57.86%   57.92%   +0.05%     
==========================================
  Files         326      326              
  Lines       25643    25643              
==========================================
+ Hits        14839    14853      +14     
+ Misses      10804    10790      -14     
Impacted Files Coverage Δ
...ove_group_interface/src/wrap_python_move_group.cpp 41.74% <ø> (ø)
...raint_samplers/src/default_constraint_samplers.cpp 84.36% <0.00%> (+0.36%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 82.99% <0.00%> (+0.68%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 77.35% <0.00%> (+0.94%) ⬆️
...nning_scene_monitor/src/planning_scene_monitor.cpp 71.53% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d015f65...e1cbf51. Read the comment docs.

@gerardcanal
Copy link
Contributor Author

@gerardcanal now you just have to rebase this one more time :-)

Rebased! :-D

@v4hn
Copy link
Contributor

v4hn commented Aug 21, 2020

Thanks again for your contributions @gerardcanal !

@v4hn v4hn merged commit ab68828 into moveit:master Aug 21, 2020
@v4hn
Copy link
Contributor

v4hn commented Aug 21, 2020

@gerardcanal If you want to see these patches in melodic-devel right way, feel free to create a backport pull-request.
Otherwise they will be backported with the next batch of things between reviewed-for-backport and master

@gerardcanal
Copy link
Contributor Author

Thank you, @v4hn. I created the backport PR :-)

v4hn pushed a commit that referenced this pull request Aug 21, 2020
pull bot pushed a commit to shadow-robot/moveit that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants