-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GILReleaser to pick & place methods #2272
Conversation
@gerardcanal now you just have to rebase this one more time :-) |
Codecov Report
@@ Coverage Diff @@
## master #2272 +/- ##
==========================================
+ Coverage 57.86% 57.92% +0.05%
==========================================
Files 326 326
Lines 25643 25643
==========================================
+ Hits 14839 14853 +14
+ Misses 10804 10790 -14
Continue to review full report at Codecov.
|
fc17062
to
e1cbf51
Compare
Rebased! :-D |
Thanks again for your contributions @gerardcanal ! |
@gerardcanal If you want to see these patches in |
Thank you, @v4hn. I created the backport PR :-) |
Description
Added the GILReleaser Pattern to the pick and place operations to prevent thread blocking when those methods were called in python.
This should be merged after #2231 (as it includes the releaser in the methods added there).
Tested in melodic, it would be good to have it ported there too.
@v4hn and @gleichdick may be good candidates for review.
Checklist