Fix some clang-tidy issues on Travis #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
requested review from
felixvd,
mlautman,
tylerjw and
v4hn
as code owners
I've seen this too and I don't know what to do with it. |
tylerjw
approved these changes
Oct 1, 2020
rhaschke
force-pushed
the
clang-tidy-fix
branch
from
7b0c5e5
to
d5a7cb9
Compare
|
Forgot to clang-format what was fixed by clang-tidy... Should be fine now. |
|
It is just a new style of aliases.
Goodbye typedef! Using using is the only proper way to define aliases by now and it annoyed me for some time already that MoveIt is still full of typedefs...
|
|
Thanks to clang-tidy this was automatically fixed now 😉 |
rhaschke
force-pushed
the
clang-tidy-fix
branch
from
8d57e85
to
3e8065c
Compare
rhaschke
commented
Oct 1, 2020
| typedef std::map<const std::pair<std::string, std::string>, std::vector<DistanceResultsData> > DistanceMap; | ||
| using DistanceMap = std::map<const std::pair<std::string, std::string>, std::vector<DistanceRequest> >; |
There was a problem hiding this comment.
Weird. clang-tidy changed the type here, replacing std::vector<DistanceResultsData> with std::vector<DistanceRequest>!
There was a problem hiding this comment.
very weird, we don't have it configured in some non-standard way do we?
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having switched to Noetic (and clang-tidy-10?) on Travis, we get some new clang-tidy issues reported:
https://travis-ci.com/github/ros-planning/moveit/jobs/393573194
Interestingly, locally I got even more issues!? There is also one "fix" applied that is nonsense: