-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix planning python scene namespacing #2347
Conversation
add a test for it
Thanks for helping in improving MoveIt and open source robotics! |
Not sure what to do about the copyright statement. I put my name there but left everything else as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please consider my inline comments so we can merge this soon.
moveit_commander/src/moveit_commander/planning_scene_interface.py
Outdated
Show resolved
Hide resolved
moveit_commander/test/python_moveit_commander_ros_namespace.test
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI is happy, then so am I.
Thanks for taking the time to add a respective test!
you'll probably want to squash before merging, lots of silly little commits here. Thanks for the speedy review! BTW, I liked your planar pushing IROS paper from this year :) |
Codecov Report
@@ Coverage Diff @@
## master #2347 +/- ##
==========================================
- Coverage 56.73% 56.71% -0.01%
==========================================
Files 281 281
Lines 25453 25457 +4
==========================================
- Hits 14437 14435 -2
- Misses 11016 11022 +6
Continue to review full report at Codecov.
|
Yes, that's documented policy here 😎
I felt obliged to do that after talking you into it. :-)
Same to you for better planning on rope handling! 👍 |
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
Description
fix planning python scene namespacing and add a test for it. Fixes #2346
Checklist