Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix planning python scene namespacing #2347

Merged
merged 5 commits into from
Oct 5, 2020

Conversation

PeterMitrano
Copy link
Contributor

Description

fix planning python scene namespacing and add a test for it. Fixes #2346

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Oct 5, 2020

Thanks for helping in improving MoveIt and open source robotics!

@PeterMitrano
Copy link
Contributor Author

Not sure what to do about the copyright statement. I put my name there but left everything else as is

Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please consider my inline comments so we can merge this soon.

Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is happy, then so am I.

Thanks for taking the time to add a respective test!

@v4hn v4hn added the awaits 2nd review one maintainer approved this request label Oct 5, 2020
@PeterMitrano
Copy link
Contributor Author

you'll probably want to squash before merging, lots of silly little commits here. Thanks for the speedy review! BTW, I liked your planar pushing IROS paper from this year :)

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #2347 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2347      +/-   ##
==========================================
- Coverage   56.73%   56.71%   -0.01%     
==========================================
  Files         281      281              
  Lines       25453    25457       +4     
==========================================
- Hits        14437    14435       -2     
- Misses      11016    11022       +6     
Impacted Files Coverage Δ
.../ompl_interface/src/detail/constrained_sampler.cpp 43.59% <0.00%> (-17.94%) ⬇️
...s/planning_interface/moveit_cpp/src/moveit_cpp.cpp 64.17% <0.00%> (-0.24%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.32% <0.00%> (-0.20%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 46.24% <0.00%> (+0.10%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.96% <0.00%> (+0.44%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 73.39% <0.00%> (+0.81%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 75.00% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023b11d...5b3416d. Read the comment docs.

@v4hn
Copy link
Contributor

v4hn commented Oct 5, 2020

you'll probably want to squash before merging, lots of silly little commits here.

Yes, that's documented policy here 😎

Thanks for the speedy review!

I felt obliged to do that after talking you into it. :-)

BTW, I liked your planar pushing IROS paper from this year :)

Same to you for better planning on rope handling! 👍

@rhaschke rhaschke merged commit c9785b6 into moveit:master Oct 5, 2020
@welcome
Copy link

welcome bot commented Oct 5, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@tylerjw tylerjw mentioned this pull request Oct 23, 2020
57 tasks
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Oct 23, 2020
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits 2nd review one maintainer approved this request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python planning scene interface incorrectly handles namespacing
3 participants