Sanitize CHOMP initialization method parameter

[onionsflying]

Return false when interpolation method is invalid.

Edit by v4hn: Additionally verify parameter during planner initialization.

[welcome]

Thanks for helping in improving MoveIt and open source robotics!

[codecov]

Codecov Report

Merging #2540 (dca390a) into master (30a170f) will decrease coverage by 0.01%.
The diff coverage is 22.23%.

@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
- Coverage   60.20%   60.19%   -0.00%     
==========================================
  Files         351      351              
  Lines       26485    26492       +7     
==========================================
+ Hits        15942    15944       +2     
- Misses      10543    10548       +5     

Impacted Files	Coverage Δ
...er/include/chomp_motion_planner/chomp_parameters.h	100.00% <ø> (ø)
...homp/chomp_motion_planner/src/chomp_parameters.cpp	83.88% <0.00%> (-16.12%)	⬇️
...s/chomp/chomp_motion_planner/src/chomp_planner.cpp	70.00% <0.00%> (-0.70%)	⬇️
...ners/chomp/chomp_interface/src/chomp_interface.cpp	95.84% <66.67%> (-4.16%)	⬇️
...raint_samplers/src/default_constraint_samplers.cpp	81.53% <0.00%> (-0.36%)	⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp	67.62% <0.00%> (+0.16%)	⬆️
...meterization/work_space/pose_model_state_space.cpp	84.56% <0.00%> (+1.48%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a170f...be3448b. Read the comment docs.

[v4hn]

Thanks for your contribution @onionsflying .
I extended your one-line patch to validate parameters during setup already.

Please verify this works for you too.

[onionsflying]

Thanks, it looks good to me. @v4hn

[simonschmeisser]

Thanks for your PR! Don't feel annoyed by my nitpicking please

[simonschmeisser]

Oh and one more thing: there's an edit link somewhere on this page and you could use it to set a more descriptive PR title (you could copy the commit message)

[welcome]

Congrats on getting your first MoveIt pull request merged and improving open source robotics!