-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make setToIKSolverFrame accessible again #2580
Conversation
This is public API because the solver's getPositionIK requires input poses in the frame and the relevant transform is otherwise inaccessible. Partially reverts moveit#2461.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me and addresses @rhaschke 's comments.
Codecov Report
@@ Coverage Diff @@
## master #2580 +/- ##
==========================================
- Coverage 60.49% 60.47% -0.02%
==========================================
Files 402 402
Lines 29606 29606
==========================================
- Hits 17907 17901 -6
- Misses 11699 11705 +6
Continue to review full report at Codecov.
|
This is public API because the solver's getPositionIK requires input poses in the frame and the relevant transform is otherwise inaccessible. Partially reverts moveit#2461.
This is public API because the solver's getPositionIK requires input poses in the frame and the relevant transform is otherwise inaccessible. Partially reverts moveit#2461.
This is public API because the solver's getPositionIK requires input poses in the frame and the relevant transform is otherwise inaccessible. Partially reverts #2461.
This is public API because the solver's getPositionIK requires input poses
in the frame and the relevant transform is otherwise inaccessible.
Partially reverts #2461.
Supersedes #2575