Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setToIKSolverFrame accessible again #2580

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Apr 6, 2021

This is public API because the solver's getPositionIK requires input poses
in the frame and the relevant transform is otherwise inaccessible.

Partially reverts #2461.

Supersedes #2575

This is public API because the solver's getPositionIK requires input poses
in the frame and the relevant transform is otherwise inaccessible.

Partially reverts moveit#2461.
Copy link
Contributor

@felixvd felixvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me and addresses @rhaschke 's comments.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2580 (954c843) into master (3361b2d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2580      +/-   ##
==========================================
- Coverage   60.49%   60.47%   -0.02%     
==========================================
  Files         402      402              
  Lines       29606    29606              
==========================================
- Hits        17907    17901       -6     
- Misses      11699    11705       +6     
Impacted Files Coverage Δ
...bot_state/include/moveit/robot_state/robot_state.h 90.91% <ø> (ø)
...on/pick_place/src/approach_and_translate_stage.cpp 73.24% <0.00%> (-0.70%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 82.70% <0.00%> (-0.64%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.27% <0.00%> (-0.54%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 81.00% <0.00%> (-0.41%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 78.61% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3361b2d...954c843. Read the comment docs.

@rhaschke rhaschke merged commit d9b93ce into moveit:master Apr 6, 2021
@tylerjw tylerjw mentioned this pull request Apr 9, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Apr 29, 2021
This is public API because the solver's getPositionIK requires input poses
in the frame and the relevant transform is otherwise inaccessible.

Partially reverts moveit#2461.
@tylerjw tylerjw mentioned this pull request Apr 29, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request May 3, 2021
This is public API because the solver's getPositionIK requires input poses
in the frame and the relevant transform is otherwise inaccessible.

Partially reverts moveit#2461.
tylerjw pushed a commit that referenced this pull request May 3, 2021
This is public API because the solver's getPositionIK requires input poses
in the frame and the relevant transform is otherwise inaccessible.

Partially reverts #2461.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants