Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bullet collision returning wrong contact type #2829

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Fix Bullet collision returning wrong contact type #2829

merged 2 commits into from
Aug 20, 2021

Conversation

yurirocha15
Copy link
Contributor

@yurirocha15 yurirocha15 commented Aug 20, 2021

Description

When using Bullet collision, the collision response contact type is wrong. This is due to a typo in the bullet_utils.h which stores the first type into both contacts.

This PR fixes this issue and updates the continuous collision detection test to include a check for the contact type.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Aug 20, 2021

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #2829 (7679fe4) into master (f8f8281) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2829      +/-   ##
==========================================
- Coverage   60.81%   60.81%   -0.00%     
==========================================
  Files         366      366              
  Lines       31717    31717              
==========================================
- Hits        19287    19285       -2     
- Misses      12430    12432       +2     
Impacted Files Coverage Δ
...detection_bullet/bullet_integration/bullet_utils.h 81.20% <100.00%> (ø)
...on/pick_place/src/approach_and_translate_stage.cpp 73.38% <0.00%> (-0.64%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 77.87% <0.00%> (-0.38%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.13% <0.00%> (-0.13%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 80.72% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f8281...7679fe4. Read the comment docs.

@v4hn
Copy link
Contributor

v4hn commented Aug 20, 2021

thank you for the patch. 🏅

@v4hn v4hn merged commit 1859ec2 into moveit:master Aug 20, 2021
@welcome
Copy link

welcome bot commented Aug 20, 2021

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@yurirocha15 yurirocha15 deleted the bugfix/bullet-contact-type branch August 20, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants