Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Rviz Panel's box size Y and Z being inverted #2847

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Fixes Rviz Panel's box size Y and Z being inverted #2847

merged 1 commit into from
Aug 26, 2021

Conversation

yurirocha15
Copy link
Contributor

@yurirocha15 yurirocha15 commented Aug 26, 2021 •
edited
Loading

Description

Currently, when adding a box to the planning scene using the MoveIt RViz panel, the size of each axis is ordered X, Z, Y. This feels quite counter-intuitive, so I guess it might be a bug.

image

panel

This PR swaps the Y and Z inputs order (making it X, Y, Z).

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@yurirocha15 yurirocha15 changed the title Fix Rviz Panel's box size Y and Z being inverted Fixes Rviz Panel's box size Y and Z being inverted Aug 26, 2021
rhaschke
rhaschke approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@rhaschke rhaschke merged commit d67d33c into moveit:master Aug 26, 2021
@yurirocha15 yurirocha15 deleted the bugfix/fix-rviz-panel branch August 26, 2021 16:29
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
@rhaschke
Migrate ros-planning org to moveit (moveit#2847)
82ef3fc 
* Rename github.com/ros-planning -> github.com/moveit
* Rename ros-planning.github.io -> moveit.github.io
* Rename ros-planning organization in docker and CI workflow files
  - ghcr.io/ros-planning -> ghcr.io/moveit
  - github.repository == 'moveit/*''
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

@felixvd felixvd Awaiting requested review from felixvd

@tylerjw tylerjw Awaiting requested review from tylerjw tylerjw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurirocha15 @rhaschke