Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comments to current parameter name #2853

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Aug 27, 2021

I just saw these comments in #2799 and they should be updated.
We renamed the parameter earlier this year because MSVC apparently reserves "near" as a keyword.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #2853 (6747ca5) into master (bd981fb) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2853      +/-   ##
==========================================
+ Coverage   60.84%   60.88%   +0.05%     
==========================================
  Files         366      366              
  Lines       31709    31709              
==========================================
+ Hits        19289    19302      +13     
+ Misses      12420    12407      -13     
Impacted Files Coverage Δ
...bot_state/include/moveit/robot_state/robot_state.h 85.04% <ø> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.27% <0.00%> (+0.14%) ⬆️
...raint_samplers/src/default_constraint_samplers.cpp 80.72% <0.00%> (+0.30%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 71.30% <0.00%> (+1.86%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 83.02% <0.00%> (+1.89%) ⬆️
.../ompl_interface/src/detail/constrained_sampler.cpp 59.46% <0.00%> (+16.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd981fb...6747ca5. Read the comment docs.

@v4hn v4hn merged commit d381f5a into moveit:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant