Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninitialized orientation in default shape pose #2896

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Oct 5, 2021

I wonder why I failed to see this during the review...

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #2896 (546e85b) into master (35275a0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2896      +/-   ##
==========================================
+ Coverage   60.95%   60.97%   +0.02%     
==========================================
  Files         373      373              
  Lines       31740    31742       +2     
==========================================
+ Hits        19344    19351       +7     
+ Misses      12396    12391       -5     
Impacted Files Coverage Δ
moveit_core/planning_scene/src/planning_scene.cpp 63.91% <100.00%> (+0.07%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 80.51% <0.00%> (-2.51%) ⬇️
...g_scene_interface/src/planning_scene_interface.cpp 48.56% <0.00%> (-1.15%) ⬇️
...on/pick_place/src/approach_and_translate_stage.cpp 73.38% <0.00%> (-0.64%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 77.87% <0.00%> (-0.38%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 78.94% <0.00%> (-0.29%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 71.30% <0.00%> (+1.86%) ⬆️
moveit_core/robot_model/src/joint_model_group.cpp 63.86% <0.00%> (+2.12%) ⬆️
...e/src/parameterization/model_based_state_space.cpp 71.33% <0.00%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35275a0...546e85b. Read the comment docs.

@simonschmeisser simonschmeisser merged commit d57721c into moveit:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants