Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Ruckig tests #3300

Merged
merged 3 commits into from Dec 21, 2022
Merged

Debug Ruckig tests #3300

merged 3 commits into from Dec 21, 2022

Conversation

AndyZe
Copy link
Contributor

@AndyZe AndyZe commented Dec 21, 2022

In order to get this test passing reliably, increase the allowable trajectory duration.

@AndyZe AndyZe marked this pull request as draft December 21, 2022 16:02
@AndyZe AndyZe marked this pull request as ready for review December 21, 2022 17:12
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 61.43% // Head: 61.97% // Increases project coverage by +0.55% 🎉

Coverage data is based on head (d324aa9) compared to base (9e5c775).
Patch coverage: 66.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3300      +/-   ##
==========================================
+ Coverage   61.43%   61.97%   +0.55%     
==========================================
  Files         380      380              
  Lines       33593    33595       +2     
==========================================
+ Hits        20635    20818     +183     
+ Misses      12958    12777     -181     
Impacted Files Coverage Δ
...rajectory_processing/src/ruckig_traj_smoothing.cpp 91.40% <66.67%> (+91.40%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 81.18% <0.00%> (-0.58%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 78.28% <0.00%> (+0.38%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 75.76% <0.00%> (+0.61%) ⬆️
...g_scene_interface/src/planning_scene_interface.cpp 52.20% <0.00%> (+1.10%) ⬆️
...eit_core/robot_trajectory/src/robot_trajectory.cpp 68.54% <0.00%> (+1.13%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 74.39% <0.00%> (+2.48%) ⬆️
...eit_ros/manipulation/pick_place/src/pick_place.cpp 92.39% <0.00%> (+3.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Seems to fix the test. Thanks!

@rhaschke rhaschke merged commit 8f4d313 into moveit:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants