New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Kinetic clang format #367
Conversation
Note: Travis will fail for clang-format test until I upgrade
|
ping - any thoughts on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delays...
I like it! There is no reason to hang on to 3.6 if 3.8 is already available in trusty.
Please go ahead!
I will merge all three PRs once I verify the moveit_ci one is working |
d6e7618
to
9cadf5a
Compare
I have just re-run clang-format 3.8 on the latest repo and am ready to merge this when CI passes |
9cadf5a
to
d44ff4f
Compare
@davetcoleman I assume we should also upgrade the indigo and jade branches? |
This is similar to @v4hn's #344 except it only upgrades us to 3.8 since that is still included in Ubuntu Trusty (ROS Indigo/Jade) but 3.9 is not
I had to apply some new settings to keep the formatting almost the same, still there are some changes that despite an hour of searching I could not figure out how to disable. Also included are some formatting fixes that were evidently a bug in 3.6:
Added:
In addition, this PR fixes a bug in our current setup as pointed out by @bmagyar here that pointer/reference symbol alignment to the variable type is inconsistent - sometimes it is aligned to the variable name instead of type. Upon investigation I discovered it is because we had the setting
DerivePointerBinding: true
- meaning:I've disabled this so that all pointers are aligned to type. This is not explicitly specified in the ROSCpp style guidelines and according to the Google style guidelines it does not matter which you use, but looking at ros_comm they use the standard of type aligned which I prefer. I think we should be consistent throughout MoveIt!.
@rbbg @v4hn