MSA: use qt4-compatible API for default font #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed for the lunar test due to unrelated reasons (console output timeout). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently remove the hard-coded "Arial" font family from MSA
and instead detect the default font via Qt.
However, the QGuiApplication class only exists in qt5 and thus
current kinetic-devel is broken with ROS indigo (qt4).
We agreed the current development branch should support
the target platforms of all other active branches of MoveIt
as long as someone is willing to provide the patches.
I propose to move from
QGuiApplication()::font().family()toQFont().defaultFamily().The latter is pretty much a stub in Qt4 (it only provides one out of 5-6 different hard-coded strings),
but the API exists in both Qt4 and Qt5.