-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup #663 #724
cleanup #663 #724
Conversation
... because it was passed by-value instead of by-reference
return value is not needed for vector versions (zero size indicates no elements)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the need to break (released) API just because it's redundant.
But I do approve the change set as is.
@rhaschke @jeffreyling sorry for the simple oversight...
Tests for the PlanningScene #667 would have helped, but nobody got around to review this yet. I'll merge this to fix the bug and remove the release blocker. |
@velveteenrobot As we had a regression after accepting your original PR #663, may I ask you to provide some unittests that validate the API to interact with the planning scene? This will help to avoid regression issues in future. |
I probably won't get around to this for like a month but if no one beats me to it, I should be able to put in some unit tests in January. |
Thanks. That would be great. |
This PR provides some cleanup to the previously merged PR #663.
As a major regression, after #663, displaying of attached collision objects didn't work anymore (#723).
Besides fixing this, the present PR provides some other minor improvements.