Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dynamic reconfigure limits for allowed_goal_duration_margin to 30s #993

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Change dynamic reconfigure limits for allowed_goal_duration_margin to 30s #993

merged 1 commit into from
Nov 4, 2018

Conversation

stwirth
Copy link
Contributor

@stwirth stwirth commented Jul 20, 2018

Description

Trivial change: increase dynamic reconfigure upper limit for TrajectoryExecutionManager allowed_goal_duration_margin.

Checklist

  • Required: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Optional: Created tests, which fail without this PR reference
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)

@jonbinney jonbinney assigned jonbinney and unassigned jonbinney Nov 3, 2018
@jonbinney jonbinney self-requested a review November 3, 2018 22:15
jonbinney
jonbinney approved these changes Nov 3, 2018
View reviewed changes
Copy link
Contributor

@jonbinney jonbinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Definitely seems like there could be reasonable cases where this value should be greater than 5 seconds. +1 for merging.

@rhaschke rhaschke merged commit 09430c1 into moveit:kinetic-devel Nov 4, 2018
v4hn pushed a commit that referenced this pull request Nov 9, 2018
@stwirth @v4hn
Change dynamic reconfigure limits for allowed_goal_duration_margin to…
62fbd20 
… 30s (#993)
@v4hn
Copy link
Contributor

v4hn commented Nov 9, 2018

cherry-picked to melodic

@rhaschke
Copy link
Contributor

rhaschke commented Nov 9, 2018

Thanks! I missed this that.

pull bot pushed a commit to shadow-robot/moveit that referenced this pull request Sep 3, 2020
@stwirth @pull
Change dynamic reconfigure limits for allowed_goal_duration_margin to…
318251d 
… 30s (moveit#993)
JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Mar 24, 2022
@henningkayser
Fix IKFast test dependency (moveit#993)
d01ef48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbinney jonbinney jonbinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stwirth @v4hn @rhaschke @jonbinney