Revert API change due to corrected ObjectConstPtr typedef. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,7 +111,7 @@ namespace collision_detection | |||
| ObjectConstPtr getObject(const std::string &id) const; | |||
|
|
|||
| /** iterator over the objects in the world. */ | |||
| typedef std::map<std::string, ObjectPtr>::const_iterator const_iterator; | |||
| typedef std::map<std::string, ObjectConstPtr>::const_iterator const_iterator; | |||
There was a problem hiding this comment.
Note that this is not really required, since the two types are actually the same. Not sure why I also reverted this to be honest...
15 tasks
JafarAbdi
pushed a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #77 (cherry-picked from #70) a typedef for
ObjectConstPtrwas fixed to actually be a pointer-to-const, but it appears in the public API in a number of places. To avoid API breakage within indigo, this PR reverts the specific changes that touch the API. See also #98.Note: This should not be cherry-picked to Jade or Kinetic.