-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSA] SRDF Setup #1057
[MSA] SRDF Setup #1057
Conversation
Please target the |
@DLu thanks a ton for the PR. I'll review this tomorrow and get back to you. In the meantime do we want to merge immediately with the bug you mentioned or hold until it's resolved. It seemed critical enough to me. |
Nah, let's review and investigate the bug here |
Codecov Report
@@ Coverage Diff @@
## feature/msa #1057 +/- ##
============================================
Coverage 57.86% 57.86%
============================================
Files 307 307
Lines 25918 25918
============================================
Hits 14996 14996
Misses 10922 10922 Continue to review full report at Codecov.
|
clang-tidy has a few complaints @DLu |
Fixed the major bug. Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this and looks good
Description
Squashed Bug
Edit: I fixed this with 5f77106
As mentioned inMIGRATION.md
there is currently a bug that I can't figure out. Steps to reproduce:Start MSA with new configurationConfigure a PlanningGroupTry to make a pose for your new Group. It should give you an error because it can't find the associatedJointModelGroup
Checklist