-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port robot_model_loader to ROS2 #109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20baaa5
to
f0e606c
Compare
moveit_ros/planning/robot_model_loader/include/moveit/robot_model_loader/robot_model_loader.h
Outdated
Show resolved
Hide resolved
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
JafarAbdi
commented
Nov 8, 2019
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
henningkayser
approved these changes
Nov 8, 2019
f11a8fd
to
269455c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library is not enabled in the CMakeLists.txt yet.
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp
Outdated
Show resolved
Hide resolved
269455c
to
0d87732
Compare
64f04c5
to
04f5013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I didn't apply this commit nor the changes to CMakeLists.txt from this commit
This PR depends on PR#104 and PR#107.