Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port robot_model_loader to ROS2 #109

Merged
merged 2 commits into from
Dec 7, 2019

Conversation

JafarAbdi
Copy link
Contributor

@JafarAbdi JafarAbdi commented Oct 27, 2019

Description

I didn't apply this commit nor the changes to CMakeLists.txt from this commit

This PR depends on PR#104 and PR#107.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library is not enabled in the CMakeLists.txt yet.

@henningkayser henningkayser merged commit 233b7cf into moveit:master Dec 7, 2019
MoveIt2 Beta - Phase 1 automation moved this from Review in progress to Done Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants