Fixup moveit_core #125
Merged
Fixup moveit_core #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoll
approved these changes
Nov 20, 2019
| @@ -675,15 +668,15 @@ FCLGeometryConstPtr createCollisionGeometry(const shapes::ShapeConstPtr& shape, | |||
| { | |||
| if (cache_it->second->collision_geometry_data_->ptr.raw == data) | |||
| { | |||
| // RCLCPP_DEBUG(LOGGER_COLLISION_DETECTION, "Collision data structures for object %s retrieved from | |||
| // RCLCPP_DEBUG(LOGGER, "Collision data structures for object %s retrieved from | |||
There was a problem hiding this comment.
maybe delete this debug code? same for lines 679--682, 708--711, and 742--745.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the majority of code fixes in order to to get
moveit_coreto compile.This mostly involves logging, faulty includes and references.
I created this PR in order to make reviewing #117 easier.