Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSA] Initial Controllers and Simulation Steps Port #1252

Merged
merged 1 commit into from
May 16, 2022

Conversation

DLu
Copy link
Contributor

@DLu DLu commented May 16, 2022

Description

To move toward merging the feature/msa feature branch, this PR moves the two steps that have yet to be fully ported to their own packages where they won't be built. I'll open separate issues to discuss what is left to be ported.

The package moveit_setup_controllers compiles and "works" in that it generates the controllers needed for ROS 1 / ros_control, and it needs to be updated for ROS 2 Control.

The package moveit_setup_simulation does not compile, and has not been updated for the latest flavor of Gazebo.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link

mergify bot commented May 16, 2022

Please target the main branch for development, we will backport the changes to feature/msa for you if approved and if they don't break API.

@vatanaksoytezer vatanaksoytezer merged commit 1f0fd41 into moveit:feature/msa May 16, 2022
@DLu DLu deleted the control_and_sim_ports branch May 16, 2022 18:52
DLu added a commit to DLu/moveit2 that referenced this pull request May 19, 2022
DLu added a commit to DLu/moveit2 that referenced this pull request May 19, 2022
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
abake48 pushed a commit to abake48/moveit2 that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants