Re-enable moveit_ros_planning & CMakeLists fixes #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JafarAbdi
force-pushed
the
pr-moveit_ros_planning_fixes
branch
3 times, most recently
from
abe97fc
to
f73fb56
Compare
JafarAbdi
force-pushed
the
pr-moveit_ros_planning_fixes
branch
from
f73fb56
to
d92e06c
Compare
henningkayser
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reason why I added
moveit_rdf_loaderandmoveit_kinematics_plugin_loaderintarget_link_librariesbecause they don't have a*Config.cmakefile, after makingmoveit_kinematics_plugin_loaderlibrarySHAREDI got some weird linking errors fixed them by adding the dependencies from the same package intarget_link_librariesament_target_dependencies reference
Checklist