Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const ptr to jmg arg for cost function #1537

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Aug 25, 2022

Signed-off-by: Tyler Weaver tyler@picknik.ai

Description

This shouldn't break anything and is more consistent with the use of jmg. @wyattrees did you have some reason to make this a non-const ptr?

Also, @wyattrees why does this cost function take a single pose and not a vector of poses?

@tylerjw tylerjw requested a review from wyattrees August 25, 2022 03:39
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1537 (77e3485) into main (888fc53) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 77e3485 differs from pull request most recent head ec630c7. Consider uploading reports for the commit ec630c7 to get more accurate results

@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
+ Coverage   50.98%   50.99%   +0.02%     
==========================================
  Files         380      380              
  Lines       31768    31768              
==========================================
+ Hits        16193    16197       +4     
+ Misses      15575    15571       -4     
Impacted Files Coverage Δ
...e/include/moveit/kinematics_base/kinematics_base.h 76.32% <ø> (ø)
moveit_core/robot_state/src/robot_state.cpp 47.44% <0.00%> (+0.08%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.43% <0.00%> (+1.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tylerjw tylerjw merged commit 389a5a8 into moveit:main Aug 25, 2022
@tylerjw tylerjw deleted the const_ptr branch August 25, 2022 18:42
@tylerjw tylerjw added the backport-humble Mergify label that triggers a PR backport to Humble label Oct 11, 2022
mergify bot pushed a commit that referenced this pull request Oct 11, 2022
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
(cherry picked from commit 389a5a8)
tylerjw pushed a commit that referenced this pull request Oct 11, 2022
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
(cherry picked from commit 389a5a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants