Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinematics base: lookup param default value fix #154

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Kinematics base: lookup param default value fix #154

merged 1 commit into from
Jan 16, 2020

Conversation

JafarAbdi
Copy link
Member

Description

This line was deleted in the kinematics_base port, this PR restore it -- this's needed for the moveit_kinematics unit tests to pass

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@JafarAbdi JafarAbdi mentioned this pull request Jan 16, 2020
Merged
7 tasks
@henningkayser henningkayser merged commit 30e060e into moveit:master Jan 16, 2020
@JafarAbdi JafarAbdi deleted the pr-kinematics_base_fix branch January 16, 2020 11:31
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
@tlpss
fix deprecated implicit conversion (moveit#154)
ae70dd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JafarAbdi @henningkayser