[Servo] Use a WallRate so the clock is monotonically increasing #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1543 +/- ##
==========================================
+ Coverage 51.06% 51.11% +0.05%
==========================================
Files 380 380
Lines 31802 31802
==========================================
+ Hits 16238 16253 +15
+ Misses 15564 15549 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
CI has passed 3X in a row now. I'm going to see if I can re-enable some of the tests that were previously commented. |
AndyZe
force-pushed
the
andyz/steady_clock
branch
from
9f24667
to
f871086
Compare
vatanaksoytezer
approved these changes
Aug 30, 2022
|
@AndyZe do you want to try to re-enable other tests in this PR or is this good to merge? |
I tried re-enabling them but saw some compiler errors because the API has changed, I guess. I'd be happy to push that to later. |
tylerjw
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
* [Servo] Use a WallRate so the clock is monotonically increasing * Re-enable a commented integration test (cherry picked from commit c134d89)
tylerjw
pushed a commit
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default
rclcpp::Rateuses astd::chrono::system_clock. Better to use arclcpp::WallRatehere since we only care about the change in time.Hat tip for @ChrisThrasher for bringing this type of issue to my attention.
If we're really lucky, this will fix the flaky Servo tests.