Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Ogre.h #1764

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

stephanie-eng
Copy link
Contributor

@stephanie-eng stephanie-eng commented Nov 28, 2022

Description

When building, I get the following message:

In file included from /workspaces/ros2-rolling-ws/src/moveit2/moveit_ros/visualization/rviz_plugin_render_tools/src/planning_link_updater.cpp:38:
/opt/ros/rolling/opt/rviz_ogre_vendor/include/OGRE/OgreVector3.h:2:62: note: ‘#pragma message: /opt/ros/rolling/opt/rviz_ogre_vendor/include/OGRE/OgreVector3.h is deprecated, migrate to Ogre.h’
    2 | #pragma message( __FILE__ " is deprecated, migrate to Ogre.h")

This PR uses Ogre.h instead of the deprecated OgreVector3.h as per the message suggests.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 50.94% // Head: 50.93% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7968b61) compared to base (3bb078d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1764      +/-   ##
==========================================
- Coverage   50.94%   50.93%   -0.00%     
==========================================
  Files         378      378              
  Lines       31671    31671              
==========================================
- Hits        16132    16129       -3     
- Misses      15539    15542       +3     
Impacted Files Coverage Δ
..._plugin_render_tools/src/planning_link_updater.cpp 0.00% <ø> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 78.79% <0.00%> (-1.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AndyZe AndyZe merged commit 8dcbe40 into moveit:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants