Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Servo dependency on realtime_tools #1791

Merged
merged 4 commits into from Jan 9, 2023

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Dec 7, 2022

Update the location of the thread_priority library which was previously lumped in with the controller_manager package

@AndyZe AndyZe requested a review from tylerjw December 7, 2022 19:08
@tylerjw
Copy link
Member

tylerjw commented Dec 7, 2022

To get this to work I think you'll have to remove ros2_control from the repos file.

moveit2.repos Outdated Show resolved Hide resolved
@tylerjw
Copy link
Member

tylerjw commented Dec 21, 2022

Per the CI failure on this one we are waiting on a Rolling sync for this to pass.

@AndyZe AndyZe force-pushed the andyz/servo_realtime_update branch from 9637da3 to fce1e02 Compare January 4, 2023 14:22
@AndyZe AndyZe force-pushed the andyz/servo_realtime_update branch from fce1e02 to 1407fda Compare January 6, 2023 18:43
@moveit moveit deleted a comment from mergify bot Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 50.45% // Head: 50.42% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (8e56d48) compared to base (165bf03).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
- Coverage   50.45%   50.42%   -0.02%     
==========================================
  Files         374      374              
  Lines       31335    31335              
==========================================
- Hits        15806    15797       -9     
- Misses      15529    15538       +9     
Impacted Files Coverage Δ
moveit_ros/moveit_servo/src/servo_calcs.cpp 65.97% <50.00%> (-1.45%) ⬇️
moveit_ros/moveit_servo/src/pose_tracking.cpp 77.11% <0.00%> (-0.46%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.95% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AndyZe AndyZe requested a review from tylerjw January 9, 2023 17:09
@mergify
Copy link

mergify bot commented Jan 9, 2023

This pull request is in conflict. Could you fix it @AndyZe?

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but keep moveit_* packages.

moveit2.repos Outdated Show resolved Hide resolved
@AndyZe AndyZe force-pushed the andyz/servo_realtime_update branch from 4bcb403 to 73eb8f8 Compare January 9, 2023 19:38
@AndyZe AndyZe requested a review from rhaschke January 9, 2023 19:38
@moveit moveit deleted a comment from mergify bot Jan 9, 2023
@rhaschke
Copy link
Contributor

rhaschke commented Jan 9, 2023

Resolves #1827

@AndyZe AndyZe merged commit 9e3f6b3 into moveit:main Jan 9, 2023
@AndyZe AndyZe deleted the andyz/servo_realtime_update branch January 9, 2023 20:58
sea-bass pushed a commit to sea-bass/moveit2 that referenced this pull request Feb 25, 2023
* Update the Servo dependency on realtime_tools

* Update .repos

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants