Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny optimizations in enforcePositionBounds() for RevoluteJointModel #1803

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Dec 12, 2022

No description provided.

}
}
return false;
return true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way for this function to fail.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 50.24% // Head: 50.25% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (0e91237) compared to base (e23fb8f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1803      +/-   ##
==========================================
+ Coverage   50.24%   50.25%   +0.01%     
==========================================
  Files         374      374              
  Lines       31277    31275       -2     
==========================================
+ Hits        15712    15713       +1     
+ Misses      15565    15562       -3     
Impacted Files Coverage Δ
...bot_model/include/moveit/robot_model/joint_model.h 82.44% <ø> (ø)
...veit_core/robot_model/src/revolute_joint_model.cpp 90.65% <100.00%> (+1.29%) ⬆️
...e/collision_detection_fcl/src/collision_common.cpp 73.76% <0.00%> (-0.22%) ⬇️
moveit_core/robot_model/src/joint_model_group.cpp 65.61% <0.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr sjahr merged commit 2e13217 into moveit:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants