MoveItConfigBuilder support for multiple instaces #1807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating two instances of
MoveItConfigBuilder
seems to be unsupported due to conflictingMoveItConfigs
.This is an example launcher to reproduce the issue test_builder.zip.
As you can notice by running the script (with the current version of the
MoveItConfigBuilder
) the attributes of two differentMoveItConfigs
(produced by two differentMoveItConfigBuilder
) share the same id and values (the one of the fanuc in the provided example).The proposed solution simply consists in moving the instatiation of the
MoveItConfigs
inside the__init__()
method ofMoveItConfigBuilder
. By doing so the problem seems to be solved (running again the script after applying the modification result in the expected behavior).