move_group: Delete unused execute_trajectory_service_capability #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyZe
commented
Dec 28, 2022
| src/default_capabilities/clear_octomap_service_capability.cpp | ||
| src/default_capabilities/tf_publisher_capability.cpp) | ||
| src/default_capabilities/tf_publisher_capability.cpp | ||
| ) |
Codecov ReportBase: 50.46% // Head: 50.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
==========================================
- Coverage 50.46% 50.42% -0.03%
==========================================
Files 374 374
Lines 31335 31335
==========================================
- Hits 15809 15799 -10
- Misses 15526 15536 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
henningkayser
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Thanks! The message type has been deprecated for a while know in favor of the "EcxecuteTrajectory" action. Could you also remove https://github.com/ros-planning/moveit_msgs/blob/ros2/srv/ExecuteKnownTrajectory.srv along with this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You can tell this file was unused because the header file it includes doesn't even exist anymore. I think somebody just forgot to delete this file.