Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci-testing build issues #1998

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Mar 9, 2023

@henningkayser henningkayser added the backport-humble Mergify label that triggers a PR backport to Humble label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b68db4e) 50.30% compared to head (31e07d3) 50.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1998      +/-   ##
==========================================
- Coverage   50.30%   50.30%   -0.00%     
==========================================
  Files         374      374              
  Lines       31358    31358              
==========================================
- Hits        15773    15772       -1     
- Misses      15585    15586       +1     
Impacted Files Coverage Δ
...include/moveit/robot_trajectory/robot_trajectory.h 98.67% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henningkayser henningkayser changed the title Fix unreachable child logger instance Fix ci-testing build issues Mar 9, 2023
@rhaschke
Copy link
Contributor

Instead of manually fixing naming-related clang-tidy issues when they pop up, somebody should take the time and finish #1949.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants