Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Variable PROJECT_NAME in CMakeLists.txt with the actual name #2020

Merged
merged 11 commits into from
Apr 20, 2023
Merged

Replace Variable PROJECT_NAME in CMakeLists.txt with the actual name #2020

merged 11 commits into from
Apr 20, 2023

Conversation

Shobuj-Paul
Copy link
Contributor

@Shobuj-Paul Shobuj-Paul commented Mar 16, 2023

Description

Replaced PROJECT_NAME variable with the contents of the project(*) in CMakeLists.txt of various packages.
Fixes #1920.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@Shobuj-Paul Shobuj-Paul marked this pull request as draft March 16, 2023 12:06
@Shobuj-Paul Shobuj-Paul marked this pull request as ready for review March 16, 2023 13:04
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (a1fce2d) 50.85% compared to head (e2c15ec) 50.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2020      +/-   ##
==========================================
- Coverage   50.85%   50.84%   -0.01%     
==========================================
  Files         391      391              
  Lines       32158    32158              
==========================================
- Hits        16350    16346       -4     
- Misses      15808    15812       +4     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Shobuj-Paul
Copy link
Contributor Author

@sjahr If you could please review the PR.

@sjahr
Copy link
Contributor

sjahr commented Apr 14, 2023

Thanks, @Shobuj-Paul, I opened a PR to address the compiler error in CI and then we're good to merge this PR!

@Shobuj-Paul
Copy link
Contributor Author

Shobuj-Paul commented Apr 14, 2023

Thanks, @Shobuj-Paul, I opened a PR to address the compiler error in CI and then we're good to merge this PR!

Cool thanks, I had opened an issue (#2113) to address the same. I think it would be safe to close it after the PR is merged.

@mergify
Copy link

mergify bot commented Apr 18, 2023

This pull request is in conflict. Could you fix it @Shobuj-Paul?

moveit_ros/moveit_servo/CMakeLists.txt Outdated Show resolved Hide resolved
moveit_ros/moveit_servo/CMakeLists.txt Outdated Show resolved Hide resolved
@Shobuj-Paul
Copy link
Contributor Author

Should I update this branch with a merge commit? Rebase has some conflicts.

@sjahr
Copy link
Contributor

sjahr commented Apr 20, 2023

Should I update this branch with a merge commit? Rebase has some conflicts.

@Shobuj-Paul No :) Looks good now, no need for you to do anything. I'll ask people for a second review and then we can merge it

@tylerjw tylerjw merged commit f0debfd into moveit:main Apr 20, 2023
@Shobuj-Paul Shobuj-Paul deleted the 1920-project-name branch April 20, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace unhelpful cmake variable PROJECT_NAME with actual package name
4 participants