-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Variable PROJECT_NAME in CMakeLists.txt with the actual name #2020
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2020 +/- ##
==========================================
- Coverage 50.85% 50.84% -0.01%
==========================================
Files 391 391
Lines 32158 32158
==========================================
- Hits 16350 16346 -4
- Misses 15808 15812 +4 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@sjahr If you could please review the PR. |
Thanks, @Shobuj-Paul, I opened a PR to address the compiler error in CI and then we're good to merge this PR! |
Cool thanks, I had opened an issue (#2113) to address the same. I think it would be safe to close it after the PR is merged. |
This pull request is in conflict. Could you fix it @Shobuj-Paul? |
Should I update this branch with a merge commit? Rebase has some conflicts. |
@Shobuj-Paul No :) Looks good now, no need for you to do anything. I'll ask people for a second review and then we can merge it |
Description
Replaced PROJECT_NAME variable with the contents of the project(*) in CMakeLists.txt of various packages.
Fixes #1920.
Checklist