Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance pilz can service request #2087

Merged

Conversation

sjahr
Copy link
Collaborator

@sjahr sjahr commented Apr 6, 2023

Description

Follow up PR to address #2082 (review)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr sjahr requested a review from henningkayser April 6, 2023 08:05
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.03 🎉

Comparison is base (cc1ef61) 50.53% compared to head (b0f28b0) 50.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
+ Coverage   50.53%   50.55%   +0.03%     
==========================================
  Files         387      387              
  Lines       31719    31734      +15     
==========================================
+ Hits        16025    16039      +14     
- Misses      15694    15695       +1     
Impacted Files Coverage Δ
...ion_planner/src/pilz_industrial_motion_planner.cpp 94.60% <75.00%> (-5.40%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henningkayser
Copy link
Member

Looks like you'll have to fix this test now https://github.com/ros-planning/moveit2/blob/main/moveit_planners/pilz_industrial_motion_planner/test/unit_tests/src/unittest_pilz_industrial_motion_planner.cpp#L148

@sjahr sjahr requested a review from henningkayser May 18, 2023 08:54
@henningkayser henningkayser merged commit 48f6e4d into ros-planning:main May 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants