-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation and cleanups for PlanningRequestAdapter and PlanningRequestAdapterChain classes #2142
Add documentation and cleanups for PlanningRequestAdapter and PlanningRequestAdapterChain classes #2142
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2142 +/- ##
==========================================
+ Coverage 50.47% 50.48% +0.01%
==========================================
Files 387 387
Lines 31790 31785 -5
==========================================
Hits 16043 16043
+ Misses 15747 15742 -5
☔ View full report in Codecov by Sentry. |
13f5d1f
to
12073ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve these changes in general. But why did you mix in the fixes for MSA and PSM, they don't seem related at all?
moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/templates.hpp
Outdated
Show resolved
Hide resolved
I thought it makes sense to apply the |
58e449f
to
1d9778e
Compare
@henningkayser I cleaned it up |
Description
Checklist