Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ikfast package template #2195

Merged
merged 3 commits into from May 23, 2023
Merged

Fix ikfast package template #2195

merged 3 commits into from May 23, 2023

Conversation

JafarAbdi
Copy link
Contributor

Description

Fix IKFastKinematicPlugin not being loaded, apply fixes from #2144 (comment)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (dcf9b3c) 50.53% compared to head (7c2df26) 50.54%.

❗ Current head 7c2df26 differs from pull request most recent head 51aa81e. Consider uploading reports for the commit 51aa81e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2195      +/-   ##
==========================================
+ Coverage   50.53%   50.54%   +0.02%     
==========================================
  Files         387      387              
  Lines       31725    31725              
==========================================
+ Hits        16029    16033       +4     
+ Misses      15696    15692       -4     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JafarAbdi
Copy link
Contributor Author

sonarcloud is failing for some reason

2023-05-22T19:49:08.1225373Z 19:49:08.122 DEBUG: Ref[refs/remotes/pull/2195/merge=7d6b0d5de20c2e9fd06b6a785c10eae7c844eb68(-1)]
2023-05-22T19:49:08.1230083Z 19:49:08.122 DEBUG: SCM reported changed lines for 0 files in the branch
2023-05-22T19:49:08.1231550Z 19:49:08.123 INFO: SCM writing changed lines (done) | time=19ms
2023-05-22T19:49:09.5160397Z 19:49:09.512 INFO: Analysis report generated in 1479ms, dir size=213 KB
2023-05-22T19:49:09.5222718Z 19:49:09.522 INFO: Analysis report compressed in 9ms, zip size=42 KB
2023-05-22T19:49:09.5223774Z 19:49:09.522 INFO: Analysis report generated in /home/runner/work/moveit2/moveit2/.scannerwork/scanner-report
2023-05-22T19:49:09.5224242Z 19:49:09.522 DEBUG: Upload report
2023-05-22T19:49:10.3661245Z 19:49:10.365 DEBUG: POST 404 https://sonarcloud.io/api/ce/submit?organization=moveit&projectKey=ros-planning_moveit2&characteristic=pullRequest%3D2195 | time=843ms
2023-05-22T19:49:10.3706289Z 19:49:10.370 INFO: ------------------------------------------------------------------------
2023-05-22T19:49:10.3706891Z 19:49:10.370 INFO: EXECUTION FAILURE
2023-05-22T19:49:10.3707495Z 19:49:10.370 INFO: ------------------------------------------------------------------------
2023-05-22T19:49:10.3708244Z 19:49:10.370 INFO: Total time: 47.920s
2023-05-22T19:49:10.4668648Z 19:49:10.465 ERROR: Error during SonarScanner execution
2023-05-22T19:49:10.4668994Z 19:49:10.465 INFO: Final Memory: 37M/127M
2023-05-22T19:49:10.4670572Z Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator
2023-05-22T19:49:10.4672677Z 19:49:10.465 INFO: ------------------------------------------------------------------------
2023-05-22T19:49:10.7995404Z ##[error]Process completed with exit code 2.

@henningkayser
Copy link
Member

@JafarAbdi should this be backported to humble?

@JafarAbdi JafarAbdi added the backport-humble Mergify label that triggers a PR backport to Humble label May 23, 2023
@JafarAbdi JafarAbdi merged commit 21036b5 into moveit:main May 23, 2023
7 checks passed
@JafarAbdi JafarAbdi deleted the pr-fix_ikfast branch May 23, 2023 14:52
mergify bot pushed a commit that referenced this pull request May 23, 2023
(cherry picked from commit 21036b5)
JafarAbdi added a commit that referenced this pull request May 23, 2023
(cherry picked from commit 21036b5)

Co-authored-by: Jafar <cafer.abdi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants