Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old deprecated functions #2384

Merged

Conversation

rmessaou
Copy link
Contributor

@rmessaou rmessaou commented Sep 24, 2023

Description

Issue: 1933
Removed old deprecated functions that are not used anymore (older than 10 months)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08% 🎉

Comparison is base (94fea79) 50.74% compared to head (d2a889e) 50.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2384      +/-   ##
==========================================
+ Coverage   50.74%   50.81%   +0.08%     
==========================================
  Files         386      386              
  Lines       31970    31926      -44     
==========================================
+ Hits        16219    16220       +1     
+ Misses      15751    15706      -45     
Files Changed Coverage Δ
...eld/include/moveit/distance_field/distance_field.h 100.00% <ø> (ø)
...e_field/include/moveit/distance_field/voxel_grid.h 95.32% <ø> (ø)
moveit_core/distance_field/src/distance_field.cpp 29.56% <ø> (+1.42%) ⬆️
...e/include/moveit/kinematics_base/kinematics_base.h 76.32% <ø> (ø)
...ene/include/moveit/planning_scene/planning_scene.h 43.55% <ø> (-0.71%) ⬇️
moveit_core/planning_scene/src/planning_scene.cpp 52.06% <ø> (+0.27%) ⬆️
...t_state/include/moveit/robot_state/attached_body.h 100.00% <ø> (ø)
...bot_state/include/moveit/robot_state/robot_state.h 90.14% <ø> (ø)
moveit_core/robot_state/src/robot_state.cpp 51.10% <ø> (+0.68%) ⬆️
...include/moveit/robot_trajectory/robot_trajectory.h 98.67% <ø> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr linked an issue Sep 25, 2023 that may be closed by this pull request
Copy link
Collaborator

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup! Just one small questions. Otherwise this should be good to go 👍

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@tylerjw tylerjw merged commit 9654bc1 into ros-planning:main Sep 29, 2023
8 checks passed
m-elwin pushed a commit to m-elwin/moveit2 that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Find and remove long-deprecated features
4 participants