Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move validateParams() out of the Servo control loop #2412

Open
AndyZe opened this issue Oct 7, 2023 · 2 comments
Open

Move validateParams() out of the Servo control loop #2412

AndyZe opened this issue Oct 7, 2023 · 2 comments
Labels
E-medium Medium Effort persistent Allows issues to remain open without automatic stalling and closing. servo

Comments

@AndyZe
Copy link
Member

AndyZe commented Oct 7, 2023

As mentioned here: #2396 (comment)

validateParams() is expensive. It doesn't belong in a control loop. Some options are:

  • Move the parameter loading out of the Servo class completely
  • Only validate parameters that have changed at runtime. Not sure if this is possible
  • Not validate parameters at all after initialization. Assume the user knows what they're doing
@AndyZe AndyZe added the bug Something isn't working label Oct 7, 2023
@ibrahiminfinite
Copy link
Contributor

Not validate parameters at all after initialization. Assume the user knows what they're doing

I prefer this way if it is acceptable, can avoid some complexity as well.

Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Nov 24, 2023
@sea-bass sea-bass added persistent Allows issues to remain open without automatic stalling and closing. and removed bug Something isn't working labels Dec 5, 2023
@tylerjw tylerjw removed their assignment Dec 12, 2023
@sea-bass sea-bass removed the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium Medium Effort persistent Allows issues to remain open without automatic stalling and closing. servo
Projects
None yet
Development

No branches or pull requests

6 participants