Re-enable waiting for current state in MoveItCpp #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
approved these changes
Oct 10, 2023
henningkayser
added
backport-humble
tylerjw
approved these changes
Oct 10, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit 0891deb)
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit 0891deb)
sjahr
pushed a commit
that referenced
this pull request
Oct 11, 2023
henningkayser
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't recall why exactly this has been commented out, but this is ancient and there have been several related fixes to the CSM. I tested this and didn't run into any issues, works as intended.