Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against zero frequency in TrajectoryMonitorMiddlewareHandler #2423

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Protect against zero frequency in TrajectoryMonitorMiddlewareHandler #2423

merged 2 commits into from
Oct 10, 2023

Conversation

sea-bass
Copy link
Contributor

I was seeing a stack trace in the tutorials on rolling when trying to execute a motion with the Kinova Gen3 robot.

Turns out the issue was trying to construct an rclcpp::Rate with zero frequency in the TrajectoryMonitorMiddlewareHandle class, so this PR fixes that.

@sea-bass sea-bass self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e37b956) 50.88% compared to head (1b072c4) 50.38%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
- Coverage   50.88%   50.38%   -0.50%     
==========================================
  Files         386      385       -1     
  Lines       31983    31814     -169     
==========================================
- Hits        16271    16025     -246     
- Misses      15712    15789      +77
Files Coverage Δ
...nitor/src/trajectory_monitor_middleware_handle.cpp 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass added backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron labels Oct 10, 2023
@tylerjw tylerjw merged commit 831c260 into main Oct 10, 2023
11 checks passed
@tylerjw tylerjw deleted the fix-traj-monitor-middleware-handle branch October 10, 2023 22:19
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
@sea-bass @mergify
Protect against zero frequency in TrajectoryMonitorMiddlewareHandler (#…
83954c5 
…2423)

(cherry picked from commit 831c260)
@mergify mergify bot mentioned this pull request Oct 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
@sea-bass @mergify
Protect against zero frequency in TrajectoryMonitorMiddlewareHandler (#…
8a511b7 
…2423)

(cherry picked from commit 831c260)
@mergify mergify bot mentioned this pull request Oct 10, 2023
Merged
sjahr added a commit that referenced this pull request Oct 11, 2023
@mergify @sea-bass @sjahr
Protect against zero frequency in TrajectoryMonitorMiddlewareHandler (#…
f1e5be1 
…2423) (#2424)

(cherry picked from commit 831c260)

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
henningkayser pushed a commit that referenced this pull request Oct 24, 2023
@mergify @sea-bass
Protect against zero frequency in TrajectoryMonitorMiddlewareHandler …
e638c85 
…(backport #2423) (#2425)

(cherry picked from commit 831c260)

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
@sea-bass sea-bass mentioned this pull request Dec 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjw tylerjw tylerjw approved these changes

@henningkayser henningkayser Awaiting requested review from henningkayser

Assignees

@sea-bass sea-bass

Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sea-bass @tylerjw