Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring indentation in newly added trajectory Python bindings #2471

Merged
merged 2 commits into from Oct 24, 2023

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Oct 23, 2023

This is weird, but the changes in #2411 that merged without issue ended up breaking the moveit2_tutorials repo with this htmlproofer error:

Warning, treated as error:
docstring of moveit.core.robot_trajectory.PyCapsule.apply_ruckig_smoothing:2:Block quote ends without a blank line; unexpected unindent.
Error: Process completed with exit code 2.

See https://github.com/ros-planning/moveit2_tutorials/actions/runs/6617124169/job/17972803048?pr=796#step:7:20084

I think it has to do with the indents added to the block quotes in some of the new functionality added in this PR.

@sea-bass sea-bass self-assigned this Oct 23, 2023
@sea-bass sea-bass changed the title Fix docstring spacing in newly added trajectory Python bindings Fix docstring indentation in newly added trajectory Python bindings Oct 23, 2023
@sea-bass sea-bass requested review from sjahr and removed request for henningkayser October 23, 2023 18:24
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (faa4795) 50.35% compared to head (c5a9474) 50.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2471      +/-   ##
==========================================
+ Coverage   50.35%   50.43%   +0.08%     
==========================================
  Files         390      390              
  Lines       31954    31954              
==========================================
+ Hits        16087    16112      +25     
+ Misses      15867    15842      -25     
Files Coverage Δ
.../moveit_core/robot_trajectory/robot_trajectory.cpp 77.15% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr added the backport-iron Mergify label that triggers a PR backport to Iron label Oct 24, 2023
@sjahr sjahr enabled auto-merge (squash) October 24, 2023 08:24
@sjahr sjahr merged commit 19c58b8 into main Oct 24, 2023
14 of 15 checks passed
@sjahr sjahr deleted the fix-moveit-py-docstring-spacing branch October 24, 2023 10:25
mergify bot pushed a commit that referenced this pull request Oct 24, 2023
(cherry picked from commit 19c58b8)

# Conflicts:
#	moveit_py/src/moveit/moveit_core/robot_trajectory/robot_trajectory.cpp
henningkayser pushed a commit that referenced this pull request Oct 24, 2023
henningkayser pushed a commit that referenced this pull request Oct 24, 2023
…port #2471) (#2473)

(cherry picked from commit 19c58b8)

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants