Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(moveit_py) fix pyi files #2526

Merged
merged 3 commits into from
Nov 13, 2023
Merged

(moveit_py) fix pyi files #2526

merged 3 commits into from
Nov 13, 2023

Conversation

MatthijsBurgh
Copy link
Contributor

Description

Fix incorrect functions names of TrajectoryExecutionManager (We missed it in #2406)
Fix missing functions of RobotTrajectory
Fix incorrect stubgen command

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76a488b) 50.39% compared to head (079655e) 50.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2526      +/-   ##
==========================================
- Coverage   50.39%   50.29%   -0.09%     
==========================================
  Files         391      391              
  Lines       31998    31998              
==========================================
- Hits        16121    16091      -30     
- Misses      15877    15907      +30     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr merged commit 4b73edb into moveit:main Nov 13, 2023
10 of 12 checks passed
@sjahr sjahr added the backport-iron Mergify label that triggers a PR backport to Iron label Nov 13, 2023
mergify bot pushed a commit that referenced this pull request Nov 13, 2023
* (moveit_py) fix planning.pyi

* (moveit_py) add missing functions to robot_trajectory.pyi

* (moveit_py) fix command to generate stubs

(cherry picked from commit 4b73edb)

# Conflicts:
#	moveit_py/moveit/planning.pyi
@MatthijsBurgh MatthijsBurgh deleted the fix/pyi branch November 13, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants