New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate RobotState benchmarks in single file #2528
Consolidate RobotState benchmarks in single file #2528
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2528 +/- ##
==========================================
- Coverage 50.83% 50.44% -0.39%
==========================================
Files 391 390 -1
Lines 32198 32026 -172
==========================================
- Hits 16366 16151 -215
- Misses 15832 15875 +43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cleanup! The unification of the files makes sense to me. Could you add documentation for this file to make maintainability easier in the future? I think ~ one brief comment for every function + benchmark and explanation for some parameters is sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This change consolidates
robot_state_benchmark.cpp
androbot_state_jacobian_benchmark.cpp
into a singlerobot_state_benchmark.cpp
file, and adds further benchmarks for RobotState construction, copy, and forward kinematics. This is in preparation for a follow-up change to update memory management inRobotState
.The matrix multiplication / inverse tests have been fully rewritten into a gmock BENCHMARK for consistency.
Output of running:
Checklist