add rsl depend to moveit_core #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This should fix moveit#2516 - Several moveit2 packages already depend on rsl - PR moveit#2482 added a depend in moveit_core This is only broken when building all of moveit2 deps in one colcon workspace And not using rosdep because colcon uses the package.xml and rsl might not have been built Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2532 +/- ##
==========================================
+ Coverage 50.81% 50.82% +0.02%
==========================================
Files 392 391 -1
Lines 32194 32198 +4
==========================================
+ Hits 16355 16362 +7
+ Misses 15839 15836 -3 ☔ View full report in Codecov by Sentry. |
sea-bass
approved these changes
Nov 15, 2023
sjahr
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is only broken when building all of moveit2 deps in one colcon workspace And not using rosdep because colcon uses the package.xml and rsl might not have been built
Checklist