Replaced single value joint_limit_margin with list of joint_limit_margin #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2576 +/- ##
==========================================
+ Coverage 50.85% 50.86% +0.02%
==========================================
Files 388 388
Lines 32360 32363 +3
==========================================
+ Hits 16453 16458 +5
+ Misses 15907 15905 -2 ☔ View full report in Codecov by Sentry. |
Nils-ChristianIseke
force-pushed
the
main
branch
from
1db1c0a
to
52aebd3
Compare
Nils-ChristianIseke
changed the title
AndyZe
reviewed
Dec 9, 2023
AndyZe
approved these changes
Dec 10, 2023
sea-bass
approved these changes
Dec 12, 2023
… Enabling setting individual margins for each joint.
…o.cpp to give a clear error message if the size of joint_limit_margis does not match the number of joints of the move_group
Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue: #2570
Enabling individual joint_limit_margins for each joint. This is useful, for example, when different types of joints are used. One value for all margins (as before) is not necessarily suitable for all joints. E.g. when revolute and prismatic joints exist.
Checklist