Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on rsl::rsl as a non-ament dependency #2578

Merged
merged 1 commit into from Dec 6, 2023
Merged

Conversation

ChrisThrasher
Copy link
Contributor

@ChrisThrasher ChrisThrasher commented Dec 6, 2023

Description

ament_target_dependencies apparently does not work if the target it depends on is it not itself built using ament CMake macros as is the case with RSL as of version 1.0. Because of this API break in the build interface of RSL we have to switch to a vanilla target_link_libraries call to use rsl::rsl.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f596b9d) 50.46% compared to head (fe017c1) 50.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2578      +/-   ##
==========================================
+ Coverage   50.46%   50.85%   +0.39%     
==========================================
  Files         387      388       +1     
  Lines       32183    32358     +175     
==========================================
+ Hits        16238    16451     +213     
+ Misses      15945    15907      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisThrasher ChrisThrasher changed the title Depend on rsl::rsl as a non-Ament dependency Depend on rsl::rsl as a non-ament dependency Dec 6, 2023
@tylerjw tylerjw merged commit 3df6b28 into moveit:main Dec 6, 2023
10 of 11 checks passed
@sjahr sjahr added backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron labels Dec 7, 2023
mergify bot pushed a commit that referenced this pull request Dec 7, 2023
(cherry picked from commit 3df6b28)

# Conflicts:
#	moveit_core/utils/CMakeLists.txt
mergify bot pushed a commit that referenced this pull request Dec 7, 2023
(cherry picked from commit 3df6b28)

# Conflicts:
#	moveit_core/utils/CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants