Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate nodes from planning scene monitor private node #262

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

AdamPettinger
Copy link
Contributor

Description

Solves #252. I can change the actual node name if desired. The output of the ros2 node list during the demo is now

image

@AdamPettinger AdamPettinger changed the title Apply fix from ros-planning/navigation2#1940 Fix duplicate nodes from planning scene monitor private node Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #262 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   47.66%   47.67%   +0.01%     
==========================================
  Files         155      155              
  Lines       15686    15691       +5     
==========================================
+ Hits         7476     7481       +5     
  Misses       8210     8210              
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 39.53% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39059e3...007ec4a. Read the comment docs.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@henningkayser henningkayser merged commit 04760ce into moveit:master Aug 27, 2020
AndyZe pushed a commit to AndyZe/moveit2 that referenced this pull request Sep 6, 2020
@AdamPettinger AdamPettinger deleted the pr-fix_duplicate_nodes branch June 2, 2021 19:57
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Co-authored-by: Shuhao Wu <shuhao@shuhaowu.com>
Co-authored-by: Nathan Brooks <nbbrooks@gmail.com>
Co-authored-by: Anthony Baker <abake48@users.noreply.github.com>
Co-authored-by: Stephanie Eng <stephanie-eng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants