Fix Servo runtime issues #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2020
Merged
|
This PR shouldn't be squashed as it adds two unrelated (but required) fixes to Servo |
rhaschke
approved these changes
Oct 14, 2020
|
Now you squashed the commits yourself? |
Oh, you're right, that was a fault on my part... I guess it's not worth the effort to reapply this PR |
MikeWrock
pushed a commit
to MikeWrock/moveit2
that referenced
this pull request
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resets
ros2_controllersto the last version that worked with FakeJoint and Servo. We'll switch to the latest versions once there are stable APIs. Also, since the last ros2 package sync, running the component nodes in Servo would throw an InvalidServiceNameException becaues the namespace parameter in the launch files were undefined. Setting them to root "/" fixes this. @AdamPettinger