Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some format strings #587

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Fix some format strings #587

merged 2 commits into from
Aug 2, 2021

Conversation

gleichdick
Copy link
Contributor

Description

Fixed some format string errors in logging macros.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #587 (d8dcb15) into main (a1ad6cd) will increase coverage by 0.02%.
The diff coverage is 41.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
+ Coverage   46.79%   46.81%   +0.02%     
==========================================
  Files         185      185              
  Lines       19692    19692              
==========================================
+ Hits         9213     9216       +3     
+ Misses      10479    10476       -3     
Impacted Files Coverage Δ
moveit_core/robot_state/src/conversions.cpp 28.13% <0.00%> (ø)
moveit_core/robot_state/src/robot_state.cpp 29.06% <0.00%> (ø)
moveit_core/utils/src/robot_model_test_utils.cpp 73.46% <0.00%> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 0.00% <0.00%> (ø)
...ning/robot_model_loader/src/robot_model_loader.cpp 0.00% <0.00%> (ø)
...tance_field/src/collision_distance_field_types.cpp 34.05% <100.00%> (ø)
...istance_field/src/collision_env_distance_field.cpp 54.33% <100.00%> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.85% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ad6cd...d8dcb15. Read the comment docs.

@gleichdick gleichdick changed the title [WIP] Fix some format strings Fix some format strings Aug 1, 2021
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These warnings have been there for a while. Thank you!

…eld_types.cpp

Co-authored-by: Jafar Abdi <cafer.abdi@gmail.com>
@tylerjw tylerjw merged commit e56facb into moveit:main Aug 2, 2021
@gleichdick gleichdick deleted the format-strings branch August 3, 2021 09:30
christianlandgraf pushed a commit to christianlandgraf/moveit2 that referenced this pull request Aug 12, 2021
Co-authored-by: Bjar Ne <gleichdick@users.noreply.github.com>
Co-authored-by: Tyler Weaver <tylerjw@gmail.com>
Co-authored-by: Jafar Abdi <cafer.abdi@gmail.com>
tylerjw added a commit to tylerjw/moveit2 that referenced this pull request Aug 27, 2021
Co-authored-by: Bjar Ne <gleichdick@users.noreply.github.com>
Co-authored-by: Tyler Weaver <tylerjw@gmail.com>
Co-authored-by: Jafar Abdi <cafer.abdi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants