[main] Migrate to joint_state_broadcaster #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only tests are failing because moveit/moveit_resources#96 is not merged. |
|
So, as this PR depends on moveit_resources. We need to add it to moveit.repos. |
Can you add it to the repos file in this PR? |
tylerjw
reviewed
Aug 31, 2021
Codecov Report
@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 54.40% 54.40%
=======================================
Files 191 191
Lines 20094 20094
=======================================
Hits 10930 10930
Misses 9164 9164 Continue to review full report at Codecov.
|
tylerjw
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ros-controls/ros2_controllers#230 ros2_control now removed joint_state_controller in favor of joint_state_broadcaster. This PR migrates our main branch to joint_state_broadcaster. Depends on moveit/moveit_resources#96.