-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info -> Debug #692
Info -> Debug #692
Conversation
Codecov Report
@@ Coverage Diff @@
## main #692 +/- ##
=======================================
Coverage 54.16% 54.16%
=======================================
Files 192 192
Lines 20180 20180
=======================================
Hits 10929 10929
Misses 9251 9251
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hold off merging this in until we have fix for the different expected kinematics namespace this revealed?
That's a good question: Maybe @JafarAbdi or @henningkayser can chime in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hold off merging this in until we have fix for the different expected kinematics namespace this revealed?
The logs are not gone in this patch, so I don't see how the changed log-level does not reveal something anymore?
I expect you can configure the log-levels in ROS2 similarly to ROS's ROSCONSOLE_CONFIG_FILE
? If involved developers do not use this approach I would say they should set it up in their workflows to avoid spamming logs for everyone.
@v4hn last time I tried this was not yet a working feature in ROS 2. |
Yeah I also don't think this is implemented yet. We can always change it back for debugging, I just think if we push this in it will be easy to ignore the loading issue (I'm unclear on how much of an issue the loading failure is though) |
Excuse me? 😖 It seems it's still only supported to set the global log level on startup, but not the level of individual namespaces. |
Revert to original log levels of some functions that was changed in https://github.com/ros-planning/moveit2/pull/598/files#diff-25706feb6b355123a5ae63dfa987a1cdd5754087392e9623960ed74a31b56d75R59.