Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find/replace deprecated spawner.py #737

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Oct 13, 2021

Fix this warning:

[ros2 run controller_manager spawner.py panda_arm_controller-7] /home/andy/ws_ros2/install/controller_manager/lib/controller_manager/spawner.py:186: DeprecationWarning: 'spawner.py' is deprecated, please use 'spawner' (without .py extension)

@vatanaksoytezer
Copy link
Contributor

Seems, servo tests strike back consistently with this PR for some reason

@vatanaksoytezer
Copy link
Contributor

The error: [ros2 run controller_manager spawner panda_arm_controller-3] No executable found so spawner might not be available in the tag of ros2 control we are using now.

@henningkayser
Copy link
Member

This depends on #711 to succeed CI

@henningkayser
Copy link
Member

This depends on #711 to succeed CI

Also, we need rolling to be synced first. Currently, ros2_control is still on 0.8.0 there as well (which I haven't noticed before). Maybe we should hold off #711 and wait until both galactic and rolling are synced and just remove the entries from the repos file.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #737 (3643269) into main (5a27d2f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   54.25%   54.24%   -0.00%     
==========================================
  Files         195      195              
  Lines       20290    20290              
==========================================
- Hits        11006    11005       -1     
- Misses       9284     9285       +1     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.31% <0.00%> (-0.50%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.85% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a27d2f...3643269. Read the comment docs.

@henningkayser henningkayser merged commit df6dc7c into moveit:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants