Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker - Temporarily move moveit_resources under target workspace due to #885 #915

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

vatanaksoytezer
Copy link
Contributor

This should fix docker CI fails in main. I would be happy if someone (that has write access) can test this in a branch before merging.

@tylerjw tylerjw linked an issue Dec 13, 2021 that may be closed by this pull request
@vatanaksoytezer
Copy link
Contributor Author

@tylerjw tested locally, docker build completed without any issues.

@vatanaksoytezer vatanaksoytezer changed the title Docker - Temporarily move moveit_resources under target workspace due #885 Docker - Temporarily move moveit_resources under target workspace due to #885 Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #915 (f5fe074) into main (71738d9) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
+ Coverage   57.90%   57.91%   +0.01%     
==========================================
  Files         310      310              
  Lines       26072    26072              
==========================================
+ Hits        15095    15096       +1     
+ Misses      10977    10976       -1     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 53.31% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba2e77...f5fe074. Read the comment docs.

@tylerjw tylerjw merged commit 0b908a1 into moveit:main Dec 13, 2021
@vatanaksoytezer vatanaksoytezer deleted the patch-4 branch December 13, 2021 18:17
tylerjw added a commit to tylerjw/moveit2 that referenced this pull request Dec 13, 2021
tylerjw added a commit to tylerjw/moveit2 that referenced this pull request Dec 22, 2021
henningkayser pushed a commit that referenced this pull request Dec 22, 2021
* Adding PRBT config
* Port prbt packages to ROS 2
* Move PRBT into test_configs directory
* Fix pre-commit for pilz test_config
* Revert "Docker - Temporarily move moveit_resources under target workspace due to #885 (#915)"
* Reset repos file entry for moveit_resources
* prbt_support: drop all test code

Co-authored-by: Christian Henkel <post@henkelchristian.de>
Co-authored-by: Michael Görner <me@v4hn.de>
Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle circular dependency with moveit_resources in Docker builds
2 participants